OpenAPITools / OpenAPITools/openapi-generator
Security concerns due to `lazy-imports` package in the python generator
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
I don't want to be a buzzkill or step on someone's toes. Still, with that change, you are potentially pushing a dependency with nine GitHub stars and two maintainers into millions of micro-services. I'd reconsider...
Originally posted by @Thommy257 in https://github.com/OpenAPITools/openapi-generator/issues/21486#issuecomment-3220495818
Hi all,
In your latest release, v7.15.0, you included a package called lazy-imports required to run the generated API client code (see https://github.com/OpenAPITools/openapi-generator/pull/21486). Due to a lack of maintenance and public verification, this package poses a significant security risk. I suggest undoing this change or internalising it into openapi-generator.
Also, this PR probably broke many CI/CD pipelines. And for those that didn't break, many microservices got silently injected with a package not verified by a large open source community.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR 21486 and the v7.15.0 Python generator changes that introduced lazy-imports. Trace how the package becomes a runtime dependency of generated API clients, then determine whether the dependency is removed or internalized and verify generated clients no longer require the unverified package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100