OpenAPITools / OpenAPITools/openapi-generator

[REQ] [csharp] There should be a single class that inherits from JsonSerializerContext

Open
#20,895 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Is your feature request related to a problem? Please describe.

Here you can see that you can inherit once from the JsonSerializerContext class and include several classes to serialize: https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/source-generation

[JsonSerializable(typeof(WeatherForecast))]
[JsonSerializable(typeof(bool))]
[JsonSerializable(typeof(int))]
public partial class WeatherForecastContext : JsonSerializerContext
{
}

Describe the solution you'd like

It should include all the classes of the model at once:

https://github.com/OpenAPITools/openapi-generator/blob/b1f572e116c8a6c694881af380e622f67fb34848/modules/openapi-generator/src/main/resources/csharp/libraries/generichost/SourceGenerationContext.mustache#L2

Describe alternatives you've considered

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with modules/openapi-generator/src/main/resources/csharp/libraries/generichost/SourceGenerationContext.mustache at the linked location, then trace how the C# generator supplies model types to that template. The generated output should define one JsonSerializerContext containing all model classes, and the relevant generator tests should confirm that output.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.