OpenAPITools / OpenAPITools/openapi-generator

[REQ] cpp-qt-client - in the HttpHelper execute method please keep the request (m_request_content = "") and provide a getter for the request object.

Open
#20,728 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Is your feature request related to a problem? Please describe.

We often fire N REST requests to the REST server in one go, if any of these fail, then it is currently important to know which request has failed. As the request is not stored in the HttpHelper it is not possible to match the error response to the matching request.
What we currently do is edit the second line in the execute() method to keep the request_content. The m_request_content is then added to the header public section. Using the payload helper method fromJson, we can reconstruct the original request payload object.

Describe the solution you'd like

Please keep the request content object inside the HttpHelper class and make it available from the application code.

Describe alternatives you've considered

One workaround is to serially request things, but this takes a long time.
What we do is edit the second line in the execute() method to keep the request_content. The m_request_content is then added to the header. Using the method fromJson, we can reconstruct the original request payload.

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the cpp-qt-client HttpHelper execute() method and inspect how m_request_content is currently handled. Check the fromJson usage described in the issue and determine how application code can access the retained request object. Done means concurrent requests can be matched to their error responses without serializing them.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.