OpenAPITools / OpenAPITools/openapi-generator

[BUG] [csharp] Aspnetcore Optional Dictionary gives compiler error

Open
#20,588 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

When defining a generic object as optional it is represented as a dictionary. For aspnetcore emitters, the type is invalid as Dictionary?<string, Object> rather than Dictionary<string, Object>?
This will only occur for .net6 or greater or where the nullableReferenceTyps = true

Reproduced in a draft PR: #20585

openapi-generator version

7.11

OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing draft PR #20585 and the aspnetcore emitters involved in nullableReferenceTyps handling. Reproduce the generic optional-object case with .NET 6 or later, then verify that generated dictionary types compile and place the nullable marker on the value type rather than the dictionary itself.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend-api-design, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.