OpenAPITools / OpenAPITools/openapi-generator

[BUG][dart-dio] Avoid depending on `Equatable` implementation files

Open
#20,158 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

With equalityCheckMethod: equatable, an implementation file (package:equatable/src/equatable_utils.dart) is imported and the internal equals and mapPropsToHashCode functions are used.

equals was recently removed in Equatable v2.0.6 and then reverted in v2.0.7.

Suggest a fix

Would it be possible to use Equatable through the public interface instead of depending on internal code that may break again in the future?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with modules/openapi-generator/src/main/resources/dart/libraries/dio/serialization/json_serializable/class.mustache, especially the Equatable-related import and generated usage. Check how the template currently uses package:equatable/src/equatable_utils.dart, then verify that generated Dart Dio models rely only on Equatable's public interface and no implementation file. Done means the internal import and internal function dependencies are removed without breaking generated equality behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.