OpenAPITools / OpenAPITools/openapi-generator

[BUG] [KOTLIN] moshiCodeGen unable to handle additionalProperties: true

Open
#20,137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

When using moshiCodeGen, and additionalProperties is set to true in the spec: additionalProperties: true, we are unable to successfully generate models.

Error preparing GetMessages200Response: com.squareup.moshi.kotlin.codegen.ksp.AppliedType.superclasses(AppliedType.kt:46)

openapi-generator version

Using 7.10.0. I don't believe its a regression.

OpenAPI declaration file content or url
      responses:
        "200":
          description: "Successful response"
          content:
            application/json:
              schema:
                type: object
                additionalProperties: true
                properties:
                  messages:
                    description: "Description"
                    nullable: false
                    type: array
                    items:
                      $ref: "#/components/schemas/Message"
Generation Details

Using the Kotlin generator with the gradle Plugin in an Android environment.

Steps to reproduce
  1. Add additionalProperties: true to a model in your spec
  2. Set moshiCodeGen to true
        additionalProperties.set(
            mapOf(
                Pair("moshiCodeGen", "true")
            )
        )
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Kotlin generator path and the Gradle plugin configuration that enables moshiCodeGen, reproducing the supplied schema with additionalProperties: true. Trace the model-generation path to the reported Moshi codegen error, then add coverage for this schema and verify that generation completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
api, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.