OpenAPITools / OpenAPITools/openapi-generator
[BUG] Generator Spring: @Size annotation is generated for LocalDate
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
Description
When using Spring Generator the @Size annotation is generated for LocalDate. The generated code looks like this:
/**
* @return date
*/
@Valid @Size(min = 10, max = 10)
@Schema(name = "date", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
@JsonProperty("date")
public LocalDate getDate() {
return date;
}
openapi-generator version
7.9.0
OpenAPI declaration file content or url
---
"components": {
"schemas": {
"Date": {
"type": "string",
"format": "date",
"minLength": 10,
"maxLength": 10
}
}
}
Generation Details
Also the overriding the beanValidationCore.mustache does not work. It seems like the new versions didn't care about this mustache file.
The name of the generator that is used: "spring"
Suggest a fix
For LocalDate no @Size annotation should be generated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Spring generator's bean validation template, including beanValidationCore.mustache, and reproduce generation with the supplied LocalDate schema on openapi-generator 7.9.0. Trace how minLength and maxLength become annotations; done when generated LocalDate accessors no longer include @Size and the template override behavior is understood or corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100