OpenAPITools / OpenAPITools/openapi-generator

[BUG] Generator Spring: @Size annotation is generated for LocalDate

Open
#20,037 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Description

When using Spring Generator the @Size annotation is generated for LocalDate. The generated code looks like this:

  /**
   * @return date
   */
  @Valid @Size(min = 10, max = 10) 
  @Schema(name = "date", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
  @JsonProperty("date")
  public LocalDate getDate() {
    return date;
  }
openapi-generator version

7.9.0

OpenAPI declaration file content or url
---
"components": {
  "schemas": {
    "Date": {
        "type": "string",
        "format": "date",
        "minLength": 10,
        "maxLength": 10
    }
  }
}
Generation Details

Also the overriding the beanValidationCore.mustache does not work. It seems like the new versions didn't care about this mustache file.

The name of the generator that is used: "spring"

Suggest a fix

For LocalDate no @Size annotation should be generated

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Spring generator's bean validation template, including beanValidationCore.mustache, and reproduce generation with the supplied LocalDate schema on openapi-generator 7.9.0. Trace how minLength and maxLength become annotations; done when generated LocalDate accessors no longer include @Size and the template override behavior is understood or corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.