OpenAPITools / OpenAPITools/openapi-generator

[BUG] [java][restclient] Fix missing javax validation imports with list validation

Open
#19,437 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

Similar to https://github.com/OpenAPITools/openapi-generator/pull/18332, building a rest client does not include the import statements.

List<@Valid AccountRequest> accountRequest

In the above sample, Valid is not found.

openapi-generator version

7.8.0

Generation Details

Spring Boot 3, Spring Framework 6, openapi generator 7.8.0, java17

{
  "groupId":"com.test",
  "artificactId": "account-client",
  "modelPackage": "com.test.model",
  "apiPackage": "com.test.api",
  "useBeanValidation": "true,
  "useTags": true,
  "hideGenerationTimeStamp": true,
  "dateLibrary": "java8-localdatetime",
  "library": "restclient",
  "useJakartaEe": true
}
Steps to reproduce

When using the openapi generator gradle plugin:

./gradlew build

Related issues/PRs

https://github.com/OpenAPITools/openapi-generator/pull/18332

Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the generated Spring Boot 3 rest client with the Gradle plugin and the shown configuration, then run ./gradlew build. Compare the missing javax or Jakarta validation imports for List with the related PR 18332. Done means the generated client includes the required validation imports and the build succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring-boot
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.