OpenAPITools / OpenAPITools/openapi-generator

[BUG] Some rust code generation errors in jellyfin sdk

Open
#19,127 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

https://github.com/jellyfin/jellyfin-sdk-typescript

Using the latest openapi to generate rust code, there are some problems

method cannot be called on &HashMap<String, String> due to unsatisfied trait bounds

error[E0599]: the method `to_string` exists for reference `&HashMap<String, String>`, but its trait bounds were not satisfied
   --> src/apis/audio_api.rs:365:96
    |
365 |         local_var_req_builder = local_var_req_builder.query(&[("streamOptions", &local_var_str.to_string())]);
    |                                                                                                ^^^^^^^^^ method cannot be called on `&HashMap<String, String>` due to unsatisfied trait bounds
    |

ImageType cannot be formatted with the default formatter


/// Enum ImageType.
#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
pub enum ImageType {
    #[serde(rename = "Profile")]
    Profile,

}

impl ToString for ImageType {
    fn to_string(&self) -> String {
        match self {
            Self::Profile => String::from("Profile"),
        }
    }
}
error[E0277]: `ImageType` doesn't implement `std::fmt::Display`
    --> src/apis/image_api.rs:2896:181
     |
2896 | ...::urlencode(item_id), imageType=image_type, imageIndex=image_index);
     |                                    ^^^^^^^^^^ `ImageType` cannot be formatted with the default formatter
openapi-generator version

5.4.0

OpenAPI declaration file content or url

https://github.com/jellyfin/jellyfin-sdk-typescript/blob/master/openapi.json

Generation Details
Steps to reproduce
 openapi-generator-cli generate -i ./openai.json -g rust  -o ./dist-rs
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked openapi.json, run the documented openapi-generator-cli command, and inspect the generated src/apis/audio_api.rs and src/apis/image_api.rs. Use cargo check to reproduce the HashMap conversion and ImageType formatting errors; done means the generated Rust SDK compiles without these errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, rust
Domain
api, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.