[BUG] typescript-angular api.service template contains unused locals

Description

file
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

contains the below comment
/* tslint:disable:no-unused-variable member-ordering */

attempting to avoid linting errors.

However, this prevents fixers (like prettier-tslint, etc) to actually attempt and fix the the unused local vars issue.

Also note that the specific problem of unused locals will not be avoided if the TS compiler has stricter config that does not allow unused locals.

openapi-generator version

3.3.2

OpenAPI declaration file content or url

https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

/* tslint:disable:no-unused-variable member-ordering */

Suggest a fix

Disabling the tslint rule does nobody a favor as TS can still catch you out.

The fix is to properly handle the conditionals of the template to correctly declare things only when needed.

Workaround

override the template to remove the comment and use a fixer - but this is not ideal

EDIT: override the template to disable TS(provided your TS version supports it)/ESLint/TSLint checks completely as auto-generated code should be ignored from specific codebase rules.

Start with modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache and inspect its conditionals around declarations that can become unused. Remove the need for the no-unused-variable suppression by declaring locals only when required; done means generated TypeScript Angular services no longer produce unused locals under stricter compiler or lint settings.