OpenAPITools / OpenAPITools/openapi-generator

[REQ] [Java][Spring] Bean validation for primitive type for container

Open
#17,150 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: Feature
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Currently no bean validation is set for primitive data types in a container. “Only” the bean validation is set for the container.

Example:

    Foo:
      type: object
      properties:
        bars:
          type: array
          items:
            type: string
            minLength: 1
            maxLength: 10
          maxItems: 10

Generator currently

  @Size(max = 10) 
  @JsonProperty("labels")
  public Set<String> getBars() {
    return bars;
  }

Expected:

  @Size(max = 10) 
  @JsonProperty("labels")
  public Set<@Size(min=1, max = 10) String>getBars() {
    return bars;
  }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Java Spring generator's handling of container item schemas and bean validation, using the issue's array-of-string example as the reproduction case. Done means generated collections retain their container constraint and also apply the item's minLength and maxLength constraints to the primitive element type.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend-api-design, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.