OpenAPITools / OpenAPITools/openapi-generator

[BUG] [Spring] Mono<Flux<Item> is generated instead of Flux<Item> when reactive is enabled

Open
#16,883 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

With the Spring generator, with reactive enabled and responseEntity disabled.
The generated server code for operations returning array of elements must be Flux<Item> and not Mono<Flux<Item>>

openapi-generator version

7.0.1

OpenAPI declaration file content or url

modules/openapi-generator/src/test/resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yaml

Generation Details

Sample config file: modules/openapi-generator/src/test/resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yaml

Steps to reproduce

Generate and check the return type of the method findPetsByStatus

Related issues/PRs
  • #1309
Suggest a fix

Currently, the code assumes that Mono is the response wrapper to always use when reactive is enabled.
This is false when data are arrays.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with modules/openapi-generator/src/test/resources/3_0/spring/petstore-with-fake-endpoints-models-for-testing.yaml and generate the Spring server with reactive enabled and responseEntity disabled. Inspect the generated findPetsByStatus method and trace the Spring generator's response-wrapper handling; done means array responses use Flux rather than Mono<Flux>.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.