OpenAPITools / OpenAPITools/openapi-generator
Mutability test of polymorphic values depends on order of mapped models in C# generator
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
In https://github.com/OpenAPITools/openapi-generator/blob/78f3b19b58df699ef883b89a7a44531407377719/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java#L620C29-L620C30 the = should be |=, i.e. isMutatable |= modelIsMutatable(model, processed)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to line 620 in modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java; start by reading the surrounding mutability calculation and how mapped models are processed. Done means the mutability result remains true when any processed polymorphic model is mutable, regardless of model order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, java, openapi
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100