OpenAPITools / OpenAPITools/openapi-generator
[BUG] javax.annotation.NonNull added in fields even without bean validation selected
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
For some reason this annotation is added to all required fields in the java generator. This is an annotation of a deprecated java package that can barely be found, and adds a dependency to all dependent projects, even though java has standard annotations like jakarta's @NotNull. This happens even if useBeanValidation and performBeanValidation is false.
Solution : this annotation should only be included if a specific flag is set. Otherwise, it should respect the above boolean flags.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Java generator entry points that add javax.annotation.NonNull and trace how useBeanValidation and performBeanValidation are read. Verify generated output with those flags disabled and enabled, and confirm the annotation appears only under the intended flag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, openapi
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100