OpenAPITools / OpenAPITools/openapi-generator

[BUG][csharp-netcore] Nullable but required properties not respected

Open
#15,735 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

If I have a property that is required but nullable, the generated code throws during deserialization when the value is null.

openapi-generator version

6.5.0

OpenAPI declaration file content or url

spec:

"properties": {
	"deletedAt": {
		"type": "string",
		"format": "date-time",
		"nullable": true
	},
}
"required": [
	"deletedAt"
]
Generation Details

generated code:

// to ensure "deletedAt" is required (not null)
if (deletedAt == null)
{
    throw new ArgumentNullException("deletedAt is a required property for XXX and cannot be null");
}
Steps to reproduce
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the csharp-netcore generator using the OpenAPI declaration in this issue and trace the generated deserialization check shown in the report. Reproduce with a required, nullable deletedAt date-time property; done means null is accepted for that property instead of throwing, while required-property behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.