OpenAPITools / OpenAPITools/openapi-generator

[BUG][TypeScript-Fetch] The propertyName of the OneOf discriminator is incorrect.

Open
#15,702 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description
openapi-generator version

6.6.0

OpenAPI declaration file content or url
components:
  schemas:
    UnionTest:
      oneOf:
        ...
      discriminator:
        propertyName: Type
        mapping":
          ...
Generation Details
legacyDiscriminatorBehavior: false
Output
function UnionTestFromJSONTyped(json, ignoreDiscriminator) {
    switch (json['type']) {
        ...
Expected Output
function UnionTestFromJSONTyped(json, ignoreDiscriminator) {
    switch (json['Type']) {
        ...

propertyName is converted to lowerSnakeCase.
Do not change the json property name

Temporary solution
modelPropertyNaming: original

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TypeScript-Fetch generator and reproduce the issue using the supplied OpenAPI schema, propertyName setting, and legacyDiscriminatorBehavior configuration. Compare the generated discriminator access with the expected TypeScript output and verify that the JSON property name remains unchanged without relying on modelPropertyNaming: original.

Written by the indexing model from the issue text.

Assessment

Tech stack
openapi, typescript
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.