OpenAPITools / OpenAPITools/openapi-generator

[BUG] SchemaMapping does not rename model

Open
#15,118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

I'm using the pistache generator with a schemaMapping:
MyObject: org.openapi.server.model.MyObj2

As expected, MyObject is not generated, but the end point is still using it - the "MyObject.h" header file is still included, and all calls use MyObject as an argument.

I would expect MyObject refs to be replaced with MyObj2.

If I add an importMappping such as:
MyObject: org.openapitools.server.model.MyObj2

the include "MyObject.h" is now replaced by MyObj without an include. The references remain unchanged.

openapi-generator version

6.5.0

OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Pistache generator entry point and its schemaMapping handling, reproducing the MyObject to org.openapi.server.model.MyObj2 case described in the issue. Inspect the generated MyObject.h include and endpoint argument references; the bug is done when mapped references use MyObj2 consistently and MyObject is not generated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.