OpenAPITools / OpenAPITools/openapi-generator

[BUG] allOf generates false import with typescript-angular format

Open
#14,966 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

False import. When using allOf with 2 objects of different type.
image

openapi-generator version

6.4.0

OpenAPI declaration file content or url
{
  "openapi": "3.0.0",
  "info": {
    "title": "allOf bug example",
    "version": "1"
  },
  "paths": {
    "/foo": {
      "get": {
        "tags": [
          "entry"
        ],
        "responses": {
          "200": {
            "description": "200 Response"
          }
        }
      }
    }
  },
  "components": {
    "schemas": {
      "ConvertableFileSchema": {
        "type": "object",
        "properties": {
          "inputFormat": {
            "allOf": [
              {
                "$ref": "#/components/schemas/InputFormatEnum"
              },
              {
                "type": "object"
              }
            ]
          }
        }
      },
      "InputFormatEnum": {
        "type": "string"
      }
    }
  }
}
Steps to reproduce

Run openapi-generator-cli generate -i [PATH_TO_JSON] -g typescript-angular -o [OUTPUT_PATH]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the provided OpenAPI declaration through openapi-generator-cli with the typescript-angular generator and inspect the generated imports. Compare the output with the expected imports for the allOf property, then add coverage for the example so the generated client no longer contains the false import.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.