OpenAPITools / OpenAPITools/openapi-generator
[BUG] CodegenProperty IsDecimal is not true when DataType == "decimal"
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- PR merge metrics
- PR metrics pending
Description
Please see the lengthCm property in
spec:
modules/openapi-generator/src/test/resources/3_0/csharp/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml
sample:
samples/client/petstore/csharp-netcore/OpenAPIClient-generichost-net6.0
I have added this as a hotfix, but perhaps it should not be needed:
modules\openapi-generator\src\main\java\org\openapitools\codegen\languages\AbstractCSharpCodegen.java
if (property.datatypeWithEnum.equals("decimal")) {
property.isDecimal = true;
}
Bug Report Checklist
- Have you provided a full/minimal spec to reproduce the issue?
- Have you validated the input using an OpenAPI validator (example)?
- Have you tested with the latest master to confirm the issue still exists?
- Have you searched for related issues/PRs?
- What's the actual output vs expected output?
- [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description
openapi-generator version
OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java and inspect how the lengthCm property is represented from spec/modules/openapi-generator/src/test/resources/3_0/csharp/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml. Compare the generated samples/client/petstore/csharp-netcore/OpenAPIClient-generichost-net6.0 output with the expected decimal handling; done means IsDecimal is correctly true without relying on the reported hotfix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100