OpenAPITools / OpenAPITools/openapi-generator

Incorrect conversion from Openapi Spec to proto.

Open
#13,693 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)

[BUG][JAVA] Bug generating protobuf file for a json having a List of List of Transactions

Description

While generating a protobuf from an openapi spec, I am getting incorrect generation.
eg :
Input Json
{
"currentOffer":[
[
{
"date":"07/07/2022",
"amount":10000
}
]]
}

For the above schema i am getting output protobuf which shows a syntax error in the below highlighted output.

Output:
repeated array[Students] currentOffer = 123456789;

openapi-generator version

org.openapitools:openapi-generator-gradle-plugin:6.2.0

OpenAPI declaration file content or url
Steps to reproduce

Update the input json with the sample json provided above and try to generate protobuf with the json provided.

Related issues/PRs
Suggest a fix

Support can be provided for List<List>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the protobuf generation with the nested-list sample in the issue, noting that a complete OpenAPI declaration and CLI generation details are not provided. Trace the protobuf generator's handling of nested arrays and compare the generated field with valid protobuf syntax; done means the sample generates valid output representing the nested transaction list.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, openapi
Domain
api, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.