OpenAPITools / OpenAPITools/openapi-generator

[BUG] [Elm] Enums getting extra value with "UnknownEnumVariableName"

Open
#13,654 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Using the full Stripe API spec.

  • Have you validated the input using an OpenAPI validator (example)?
  • I used the CLI with validate and it found no issues.

  • Have you tested with the latest master to confirm the issue still exists?
  • Yes

  • Have you searched for related issues/PRs?
Description
openapi-generator version

Latest master

OpenAPI declaration file content or url

https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.json

Generation Details
java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate    -i https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.json    -g elm    -o ./elm-stripeFix

Some enum types turn into a custom type with a bogus constructor:

type TaxExempt
    = TaxExemptUnknownEnumVariableName
    | TaxExemptExempt
    | TaxExemptNone
    | TaxExemptReverse


taxExemptVariants : List TaxExempt
taxExemptVariants =
    [ TaxExemptUnknownEnumVariableName
    , TaxExemptExempt
    , TaxExemptNone
    , TaxExemptReverse
    ]


stringFromTaxExempt : TaxExempt -> String
stringFromTaxExempt model =
    case model of
        TaxExemptUnknownEnumVariableName ->
            ""

        TaxExemptExempt ->
            "exempt"

        TaxExemptNone ->
            "none"

        TaxExemptReverse ->
            "reverse"



... but "TaxExemptUnknownEnumVariableName" does not exist, and the spec json does not seem to indicate any other values besides the valid three...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the Elm generation command in the issue against the linked Stripe OpenAPI spec and inspect the generated TaxExempt type, variants list, and stringFromTaxExempt function. Trace the Elm generator entry point that handles enum values and compare the output with the three values in the spec. Done means no UnknownEnumVariableName constructor or empty-string mapping is generated.

Written by the indexing model from the issue text.

Assessment

Tech stack
elm, java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.