OpenAPITools / OpenAPITools/openapi-generator

[typescript] allOf fails with chained inheritance

Open
#13,417 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue: Bug
Dominant language
Java
Stars
26.8k
Forks
7.7k
PR merge metrics
PR metrics pending

Description

Bug Report Checklist
  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

Using openapigenerator 6.0.1, with generator "typescript".

If a spec uses allOf to specify an inheritance chain, the child in the inheritance chain will have its own properties and the properties of its most distant parent, but not the properties of its closest parent.

In the provided example, the instance of class Child would have Child.ChildAttribute and Child.GrandparentAttribute but not Child.ParentAttribute.

openapi-generator version

6.0.1

OpenAPI declaration file content or url

https://gist.github.com/MattiasMartens/49415a0fe5c3922500424d61c5a3c97a

Related issues/PRs

First raised in https://github.com/OpenAPITools/openapi-generator/issues/927.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the chained allOf case from the provided OpenAPI declaration with the typescript generator, comparing the generated Child class with its parent classes. Trace how the generator resolves inherited properties; done means Child includes its own, parent, and grandparent attributes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, typescript
Domain
api, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.