Open-EO / Open-EO/openeo-python-driver
Timezone and millisecond support in `date_shift`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12
- Forks
- 8
- Avg merge
- 6d 3h
- Merged PRs (30d)
- 4
Description
In 721f7bae64f I added basic implementation of date_shift process (also see Open-EO/openeo-processes#248)
Still to do:
- time zone support: e.g. see hidden test case https://github.com/Open-EO/openeo-python-driver/blob/b987baf8b40ceea4e7a695d030546c63136957ad/tests/test_views_execute.py#L1561 from example at https://github.com/Open-EO/openeo-processes/blob/bb2353011508c462a0827cc9234980a79367bdba/proposals/date_shift.json#L75-L82)
- millisecond support: e.g. see hidden test case https://github.com/Open-EO/openeo-python-driver/blob/b987baf8b40ceea4e7a695d030546c63136957ad/tests/test_views_execute.py#L1565 from example at https://github.com/Open-EO/openeo-processes/blob/bb2353011508c462a0827cc9234980a79367bdba/proposals/date_shift.json#L110-L118
Both are not supported at the moment by the Rfc3339 helper class from openeo-python-client.
Because we don't expect time zone support or millisecond support to be high priority for end users, we leave this as open todo for now.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the date_shift implementation from commit 721f7bae64f and the Rfc3339 helper in openeo-python-client. Run or inspect the referenced cases in tests/test_views_execute.py around lines 1561 and 1565, and compare them with the linked date_shift proposal examples. Done means timezone and millisecond inputs are supported and those cases pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100