Open-EO / Open-EO/openeo-python-driver
Simplify config getter and override system
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 12
- Forks
- 8
- Avg merge
- 6d 3h
- Merged PRs (30d)
- 4
Description
This came up while trying to get https://github.com/Open-EO/openeo-geopyspark-driver/pull/701 working:
configs defined in openeo-python-driver's OpenEoBackendConfig and used in openeo-python-driver can not be overriden from e.g. openeo-geopyspark-driver's gps_config_overrides as openeo-python-driver and openeo-geopyspark-driver have separate ConfigGetter instances and config_overrides only overrides one of them.
It probably pays off to simplify the config getter system a bit: just have a single ConfigGetter instance in the application. This implies that e.g. openeo-geopyspark-driver would overwrite the default one of openeo-python-driver.
Related: part of the simplification could also involve eliminating the subclass GpsConfigGetter
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how OpenEoBackendConfig, ConfigGetter, GpsConfigGetter, config_overrides, and gps_config_overrides are instantiated and used across openeo-python-driver and openeo-geopyspark-driver. The work is done when one application-level ConfigGetter lets geopyspark overrides affect driver configs, with the GpsConfigGetter subclass simplified or removed as appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100