Open-EO / Open-EO/openeo-python-driver

vector_buffer not in line with official spec

Open
#247 4 comments 0 reactions 1 assignee View on GitHub

@soxofaan is already working on this.

Since Apr 19, 2024.

API bug
Dominant language
Python
Stars
12
Forks
8
Avg merge
6d 3h
Merged PRs (30d)
4

Description

https://github.com/Open-EO/openeo-python-driver/blob/657c054bc750d1816e1a687d4ee6d19568e85d24/openeo_driver/ProcessGraphDeserializer.py#L618-L629
uses arguments:

  • singular geometry (inline geojson)
  • distance (number)
  • unit (number, and required)

Current official spec: https://github.com/Open-EO/openeo-processes/blob/965bbaebd4d5984203a0437076c85a66a72a23e0/proposals/vector_buffer.json
specifies arguments:

  • plural geometries ("vector cube")
  • distance (number)

Note that this standard API is copied over to autogenerated helper in python client: https://github.com/Open-EO/openeo-python-client/blob/7ce92925dd9544ff116b14c0339de203f854ec27/openeo/processes.py#L5497

The difference in singular/plural and the unit argument (which is required but non-standard) make future proof usage problematic

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.