Open-EO / Open-EO/openeo-python-client
Use standard retry logic in _download_ranged
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 217
- Forks
- 56
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 2
Description
as suggested in https://github.com/Open-EO/openeo-python-client/pull/933#discussion_r3770142673, replace this DIY retry logic with standard retry utilities like urllib3.util.Retry.
Actually, RestApiConnection already has such a retry config by default since https://github.com/Open-EO/openeo-python-client/pull/770 (for https://github.com/Open-EO/openeo-python-client/issues/441 and https://github.com/Open-EO/openeo-python-client/issues/764)
so the DIY retry logic can probably just be dropped
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in openeo/rest/job.py at lines 557-571 and read the existing retry logic in _download_ranged. Then inspect RestApiConnection's default retry configuration and the urllib3.util.Retry reference from the issue discussion. Done means ranged downloads use the existing standard retry configuration instead of the DIY logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100