Open-EO / Open-EO/openeo-python-client
merge_cubes: merge metadata even without band_dimensions
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 217
- Forks
- 56
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 2
Description
Currently if one or both of the cubes have missing band data the resulting metadata is set to None.
Suggested approaches:
- cube1 has bands and cube2 has bands -> current implementation
- cube1 has bands but cube2 has no bands -> take over bands of cube1 (cube2 will be merged with overlap on all bands)
- cube1 has no bands but cube 2 has bands -> See step 2 I think
- both have no bands -> use metadata from first cube
If one of both cubes has none as metadata I think it is still safer to put the result to none as well
In a better scenario the extents of all dimensions are merged but that might be the scope of a separate issue rather than include it in this one.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in openeo/rest/datacube.py at lines 2210-2224 and inspect the merge_cubes entry point. Trace how band_dimensions and metadata are handled for each of the four band-availability cases, while preserving None metadata when either input has None metadata. Done means the resulting metadata follows the stated cases without attempting the separate extent-merging scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design, data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100