Open-EO / Open-EO/openeo-python-client
Simplify openeo.udf.feature_collection.FeatureCollection
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 217
- Forks
- 56
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 2
Description
FeatureCollection in the openeo.udf.feature_collection package was a direct copy of https://github.com/Open-EO/openeo-udf/blob/master/src/openeo_udf/api/feature_collection.py, including some things that look over-engineered or are unused as far as I know:
- constructor requires a
idas (first) argument, but I have no idea where this is used, or at least which important aspect makes it a required first argument - it also takes
start_timesandend_times, but I have never seen this being used, and I guess this kind of data can easily (and more flexibly) be included in the geopandas dataframe directly
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the openeo.udf.feature_collection.FeatureCollection implementation and comparing it with the upstream src/openeo_udf/api/feature_collection.py copy. Trace whether id, start_times, and end_times are used, then define the simplified constructor and verify that the resulting API retains the required feature-collection behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100