Open-EO / Open-EO/openeo-python-client
Eliminate duplication between DataCube, VectorCube, ...
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 217
- Forks
- 56
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 2
Description
with addition of MlModel (5d074cb3b1dce3ec3db0fd9f65305719d6b6b3a5), we have now three classes that duplicate a lot of internals:
DataCubeVectorCubeMlModel
e.g. MlModel is more than 100 LoC, but only 10 is actually MlModel specific, the rest is copied from DataCube. In VectorCube it's even worse
I think these duplicated internals should be moved to a common base
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the implementations of DataCube, VectorCube, and MlModel, including the MlModel addition referenced by commit 5d074cb3b1dce3ec3db0fd9f65305719d6b6b3a5. Identify the duplicated internals that can move into a common base while preserving class-specific behavior; done means the duplication is removed without changing the three classes' public behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100