Open-EO / Open-EO/openeo-python-client

Remove band-to-index conversion feature in `cube.band()` band math method

Open
#217 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v1.0.0
Dominant language
Python
Stars
217
Forks
56
Avg merge
1d 22h
Merged PRs (30d)
2

Description

Currently, DataCube.band() provides a client side feature to convert band names to band indexes. This was for historic reasons to make band() user friendly (allowing band names) when array_element only supported band indices. Since the 1.0 branch of the openeo-processes, array_element does support band names, so it is not necessary to do this feature client side.

Moreover, doing it client side correctly is not trivial nor always feasible. E.g. see #212

Blocker: the VITO backend does not support labels in array_element so this has to be fixed first: Open-EO/openeo-geopyspark-driver#43

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DataCube.band() implementation and review issue #212 for the client-side conversion problems. Check the linked openeo-geopyspark-driver#43 blocker first; done means the VITO backend supports labels in array_element and the client-side band-name-to-index conversion is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.