Open-Acidification / Open-Acidification/TankControllerPico
Storage and Logging
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 1
- Avg merge
- 2h 22m
- Merged PRs (30d)
- 2
Description
Data is currently handled across both the EEPROM and device classes. Choose a single storage approach and rename classes to reflect clear ownership. Implement a centralized logging system (Serial or alternatives) and apply it consistently across device actions.
Related articles
- https://www.instructables.com/Data-Logging-With-Raspberry-Pi-Pico/
- https://rc2014.co.uk/modules/pi-pico-vga-terminal/pi-pico-sd-card-backpack/
For exmaple set highpoint cali in pH probe
def set_highpoint_calibration(self, highpoint):
"""
Set the highpoint calibration value for the pH probe.
"""
self.slope_is_out_of_range = False
self.eeprom.set_ignore_bad_ph_slope(False)
self._highpoint_calibration = highpoint
buffer = f"Cal,High,{int(highpoint)}.{int(highpoint * 1000 + 0.5) % 1000}\r"
print(buffer) # Simulate sending the string to the Atlas Scientific product
print(
f"PHProbe::setHighpointCalibration({int(highpoint)}.{int(highpoint * 1000) % 1000})"
)
vs cpp
serial(F("PHProbe::setHighpointCalibration(%i.%03i)"), (int)highpoint, (int)(highpoint * 1000) % 1000);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing ownership between the EEPROM and device classes, using set_highpoint_calibration as the concrete entry point and reviewing the Serial or print logging examples in the issue. Done means storage has one clear owner, classes reflect that ownership, and device actions use one centralized logging approach consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100