OneKeyHQ / OneKeyHQ/app-monorepo

Consider using react-native-quick-crypto

Open
#1,680 4 comments 2 reactions 0 assignees View on GitHub
enhancement feature request good first issue
Dominant language
TypeScript
Stars
2.4k
Forks
535
Avg merge
21h 55m
Merged PRs (30d)
497

Description

Hey!

I noticed this repo uses **react-native-crypto**, which itself uses **crypto-browserify** under the hood. **crypto-browserify** is a JS-based implementation for crypto, which is slower than Margelo's [**react-native-quick-crypto**](https://github.com/margelo/react-native-quick-crypto), since that uses C++ (OpenSSL) with JSI under the hood.

If you want to replace **react-native-crypto** with the faster **react-native-quick-crypto**, I'm happy to help out or answer questions! 😄

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the repository's use of react-native-crypto and its crypto-browserify dependency, then review react-native-quick-crypto's compatibility and setup requirements. Confirm the replacement works across the wallet's supported native platforms and compare the relevant crypto operations before considering the issue done.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native
Domain
cryptography, mobile-dev, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.