OmniSharp / OmniSharp/csharp-language-server-protocol
Internal class WorkspaceConfigurationProvider is returned from Public APIs
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 638
- Forks
- 109
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
Problem
WorkspaceConfigurationProvider [1] is an internal class but it is returned from the public GetConfiguration API.
The GetConfiguration API [2] returns multiple Providers, and I'd like to be able to distinguish between them, as VS Code configuration for a Language Client end up in a WorkspaceConfigurationProvider. However, since WorkspaceConfigurationProvider is internal you cannot type check it.
Proposed Solution
Make WorkspaceConfigurationProvider Public.
Code References
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/Server/Configuration/WorkspaceConfigurationProvider.cs and inspect how it is returned by GetConfiguration in src/Protocol/Server/ILanguageServerConfiguration.cs. Confirm the public API's provider types and any accessibility constraints. Done means consumers can identify WorkspaceConfigurationProvider through the public API, with the class exposed publicly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100