OmniSharp / OmniSharp/csharp-language-server-protocol
ILinkedEditingRangeHandler should return a nullable result
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 638
- Forks
- 109
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
The LSP spec indicates LinkedEditingRange can return either return LinkedEditingRanges or null. However, it seems like the O# ILinkedEditingRangeHandler expects a non-nullable response type: https://github.com/OmniSharp/csharp-language-server-protocol/blob/de1591e91a176fb88442ecf7e2e30f7a2174e6c0/src/Protocol/Features/Document/LinkedEditingRangeFeature.cs#L23
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/Protocol/Features/Document/LinkedEditingRangeFeature.cs at the referenced handler definition and compare its response type with the LSP linked-editing-range specification. Update the handler contract to allow the specified null result, then build the project and check affected references for compatibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100