OmniSharp / OmniSharp/csharp-language-server-protocol

Completion Request returning null response leads to an unhandled exception in the client

Open
#584 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
638
Forks
109
Avg merge
1m
Merged PRs (30d)
2

Description

As defined in the spec here Completion Request can return null:

textDocument/completion
...
Response:
result: CompletionItem[] | CompletionList | null

However, if a server returns null from Completion Request, an unhandled is thrown on client (most probably, here).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Protocol/Serialization/Converters/CompletionListConverter.cs around line 43, then compare the Completion Request response rules in the linked Language Server Protocol specification. Verify that a null completion response no longer causes an unhandled client exception; the issue does not name a test file.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.