OfficeDev / OfficeDev/Office-Addin-Scripts
eslint-plugin-office-addins: add support for ESLint 10
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 194
- Forks
- 117
- Avg merge
- 1d 32m
- Merged PRs (30d)
- 2
Description
Description
eslint-plugin-office-addins@4.0.7 crashes when used with ESLint 10 due to its bundled @typescript-eslint/utils@8.8.1 dependency, which only supports ESLint 8/9.
Error
TypeError: Class extends value undefined is not a constructor or null
at Object.<anonymous> (eslint-plugin-office-addins/node_modules/@typescript-eslint/utils/dist/ts-eslint/FlatESLint.js:12:49)
Root Cause
The plugin pins typescript-eslint: ~8.8.0 in its dependencies, which resolves @typescript-eslint/utils@8.8.1. That version declares peerDependencies: { eslint: "^8.57.0 || ^9.0.0" } — no ESLint 10 support.
The top-level @typescript-eslint/utils@8.58.1 already supports ESLint 10 (^8.57.0 || ^9.0.0 || ^10.0.0).
Suggested Fix
Update typescript-eslint dependency from ~8.8.0 to ^8.58.0 (or later) so that @typescript-eslint/utils resolves to a version that supports ESLint 10.
Environment
- eslint: 10.2.0
- eslint-plugin-office-addins: 4.0.7
- typescript-eslint: 8.58.1
- Node: $(node -v)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the eslint-plugin-office-addins package dependency declaration and inspect how its typescript-eslint version is constrained. Update the constraint to a release whose @typescript-eslint/utils supports ESLint 10, then verify the plugin loads successfully with the reported ESLint 10 environment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100