OfficeDev / OfficeDev/Office-Addin-Scripts
Remove deprecated dependency on `punycode`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 194
- Forks
- 117
- Avg merge
- 1d 32m
- Merged PRs (30d)
- 2
Description
I have an issue from customer complaining about the deprecated package punycode. https://github.com/OfficeDev/OfficeAddinDevKit/issues/15
Just did a check, it's from the node-fetch 2.6.1 which is a dependency from office-addin-cli. This version is 4 years ago so I think we do need to do an update to clean vulnerability.
I can help do the upgrade if you have limited bandwidth, but I'm not sure about the testing process after upgrading dependencies.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the office-addin-cli dependency manifests to trace node-fetch 2.6.1 and its transitive punycode dependency. Identify a supported dependency update, then find the repository's existing validation process; done means the deprecated dependency is no longer installed and the relevant checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100