OfficeDev / OfficeDev/Office-Addin-Scripts

Validate doesn’t check existence of 16px icon

Open
#807 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs triage
Dominant language
TypeScript
Stars
194
Forks
117
Avg merge
1d 32m
Merged PRs (30d)
2

Description

I created an Excel taskpane add-in for internal use, delivered through Centralized Deployment.

The add-in worked on the Web and Mac versions of Excel, but not on the Windows version.

The problem turned out to be that the manifest did not contain a 16px icon. The validation command however did not flag the error pre-deployment.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the validation command and the manifest icon checks, then reproduce the issue with a manifest that lacks a 16px icon. Done means validation reports the missing icon before deployment, with coverage for this case if the existing validation tests provide a place for it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.