OfficeDev / OfficeDev/Excel-Custom-Functions

Test scripts are not removed from package.json in custom function projects

Open
#375 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
333
Forks
69
Avg merge
3d 15h
Merged PRs (30d)
3

Description

Prerequisites

Please answer the following questions before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

  • [x ] I am running the latest version of Node and the tools
  • [x ] I checked the documentation and found no answer
  • [ x] I checked to make sure that this issue has not already been filed

Expected behavior

The test:e2e and test:unit scripts would not be in the package.json of custom function projects.

Current behavior

The test:e2e and test:unit scripts ARE in the package.json of custom function projects. They do not work. Try to run them and you get an error saying that "mocha" is not a recognized command.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Create project with yo office.
  2. Choose either of the custom function project types.
  3. Let the project be created.
  4. Open the package.json.
  5. The two test scripts are still in it.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System: Win11
  • Node version: 16.13.1
  • Office version:
  • Tool version: latest, just installed

Failure Logs

Please include any relevant log snippets, screenshots or code samples here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the yo office generator path for the two custom function project types and inspect the package.json template or generation step. Confirm how test:e2e and test:unit are added, remove them from custom function projects, and generate a project to verify those scripts are absent while other project types remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.