Consider using python objects for defining threats
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 229
- PR merge metrics
- No merged PRs in 30d
Description
The current system of using threats defined in JSON is a little bit hard to use/maintain. The conditions for a threat are written as a string, then eval'ed which is not ideal.
With the pydantic models, it should be easy to define threats as python classes and allow for type hinting, unit tests, linting etc
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the JSON threat definitions, the pydantic models, and the code path that evaluates condition strings. Review how threats are loaded and exercised today, then determine the scope of the Python-class representation, including the type hints and unit tests needed to replace the current eval-based conditions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100