OWASP / OWASP/SecurityShepherd
Add test coverage for SLS and ACS SAML auth servlets
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 515
- Avg merge
- 3h 46m
- Merged PRs (30d)
- 1
Description
Summary
The SAML SSO auth servlets SLS (Single Logout Service) and ACS (Assertion Consumer Service) have no test coverage — no unit or integration tests exist for either.
src/main/java/servlets/SLS.java — no SLSTest / SLSIT
src/main/java/servlets/ACS.java — no ACSTest / ACSIT
By contrast, the non-SAML auth servlets Login and Logout do have IT coverage (LoginIT, LogoutIT).
Why it matters
These are authentication-path servlets in a security training application — exactly the code that should be tested. The gap surfaced during the Jakarta migration (#861): OpenRewrite tried to bundle a behavioral change (ses.invalidate() → request.logout()) into these files, and for SLS/ACS there was no test that would have caught a regression (whereas LogoutIT would have).
Scope
- Add coverage for
ACS(consumes the SAML assertion / IdP response, establishes the session). - Add coverage for
SLS(handles SAML single-logout). - Cover both success and failure/invalid-assertion paths.
Note: depends on the SAML Auth API, which is being moved to the Jakarta-compatible java-saml 3.0.0 + java-saml-servlet-jakarta as part of #861 — coordinate so tests target the post-migration API.
Out of scope
MobileLogin coverage — the mobile side is handled under a separate initiative.
Discovered during #861.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/main/java/servlets/SLS.java and ACS.java, then read LoginIT and LogoutIT for the project’s integration-test patterns. Check the post-migration SAML Auth API from #861 before designing the tests. Done means coverage exists for both servlets, including successful and failure or invalid-assertion paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, backend, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100