OWASP / OWASP/SecurityShepherd
[LOG] regular fatal errors reported in log
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 515
- Avg merge
- 3h 46m
- Merged PRs (30d)
- 1
Description
Recently I checked the file security-shepherd.log to see if there were any anomalies. I was then surprised to see a relatively large number of fatal errors like this :
FATAL @ 01 Dec 19:34:44,278 https-openssl-nio-8443-exec-7 utils.Validate - User account testuser Attempting Admin functions! (With Valid CSRF Tokens)
After a short analysis, I discovered that this message is regularly issued in connection with the servlet servlets/module/GetModule.java which on line 83 is calling the method utils/Validate.validateAdminSession(ses, tokenCookie, tokenParmeter). In this method, in turn, this fatal error is output on line 274.
I noticed that every time a normal user calls up a module (lesson or challenge) in the menu for viewing, this error is reported.
Either this does not represent a fatal error, or something is going wrong in the analysis of the session....
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with servlets/module/GetModule.java at line 83 and utils/Validate at line 274. Reproduce a normal user's module view and trace validateAdminSession to determine whether the session is incorrectly classified or only logged at the wrong severity; done means ordinary module views no longer produce misleading fatal errors while admin-session validation remains accurate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100