OWASP / OWASP/SecurityShepherd

Adjust how database files are generated for docker databases

Open
#516 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.5k
Forks
515
Avg merge
3h 46m
Merged PRs (30d)
1

Description

Currently the Tomcat docker images creates a database conf file like this;

https://github.com/OWASP/SecurityShepherd/blob/b5a8038da6898c4bacfc62c7c0bc0b1b0504c32f/Dockerfile#L31

https://github.com/OWASP/SecurityShepherd/blob/b5a8038da6898c4bacfc62c7c0bc0b1b0504c32f/Dockerfile#L32

However, changes to the database options are usually reflected in the test properties file. Instead of creating this file in the docker file it should copy out the test resources and sed any configurable variables like what is currently set up in the .env file i.e. passwords.

https://github.com/OWASP/SecurityShepherd/blob/dev/src/test/resources/conf/database.properties

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the database-generation commands at Dockerfile lines 31-32, then compare them with src/test/resources/conf/database.properties and the variable handling in .env. Confirm how the Docker build copies test resources and substitutes configurable values; done means database options come from the shared properties file while passwords and other variables remain configurable.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, dockerfile, java
Domain
databases, devops
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.