OWASP / OWASP/OpenCRE

Filter ga_standards by saved selection, with ?all=true bypass

Open
#1,083 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement not ready for development P2 untriaged
Dominant language
Python
Stars
180
Forks
137
Avg merge
3d 23h
Merged PRs (30d)
21

Description

Parent: #1079 · Splits #1043 §2 · Project: https://github.com/orgs/OWASP/projects/60

What

GET /rest/v1/ga_standards feeds Map Analysis / gap-analysis dropdowns. It is not passed through apply_user_resource_filter. Completing the profile view means:

  1. Filter ga_standards the same way as /standards when the user has a non-empty selection (keep OpenCRE; empty selection = full eligible list).
  2. Frontend must pass ?all=true wherever GA should still span all eligible standards (same pattern as ResourceSelector).

Left out of #586 on purpose so we would not silently shrink the dropdowns.

Do

  • Apply apply_user_resource_filter (or equivalent) on /rest/v1/ga_standards
  • Keep GA eligibility gating (resource_name_ga_eligible_in_db)
  • Map Analysis UI: default to filtered list when a selection exists; explicit “all eligible standards” uses ?all=true
  • Tests: logged-in filtered, ?all=true bypass, anonymous full, flags off = full

Success

A user who saved ASVS+CWE sees those (if GA-eligible) in the dropdowns by default, and can still run a comparison against the full eligible set without clearing their profile.

Related

  • application/web/web_main.py ga_standards
  • application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx
  • #1043

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ga_standards entry point in application/web/web_main.py, then inspect application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx and the existing ResourceSelector ?all=true pattern. Trace how /standards applies apply_user_resource_filter while preserving GA eligibility gating. Done means the listed logged-in, bypass, anonymous, and flags-off scenarios pass, and Map Analysis defaults to the saved selection while supporting all eligible standards.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, typescript
Domain
api, backend, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.