OWASP / OWASP/Nest

Optimise process_entity_members performance

Open
#3,934 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
451
Forks
707
Avg merge
22h 59m
Merged PRs (30d)
91

Description

## Describe the bug
the `process_entity_members` in `owasp_update_leaders.py` has 2 nested loops , running in O(m*n) time, which doesn't scale well. I am confident it can be optimized to O(m+n) by implementing a look up map, increasing performance.

### To Reproduce
In the `process_entity_members` function we iterate through each leader (N). Inside this loop, we call
`find_best_user_match` which iterates through the entire list of GitHub users (M) to find a match
hence O(M*N)

### Are you going to work on fixing this?

- [x] Yes
- [ ] No

### screenshots
- NA

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.