Clarification: 1.3.4 “Draw graphics”
Open
Nobody has claimed this yet.
4a) Waiting for another
V1 (prev V5)
- Dominant language
- HTML
- Stars
- 3.6k
- Forks
- 831
- Avg merge
- 7h 55m
- Merged PRs (30d)
- 4
Description
1.3.4 Verify that user‑supplied Scalable Vector Graphics (SVG) scriptable content is
validated or sanitized to contain only tags and attributes (such as draw
graphics) that are safe for the application, e.g., do not contain scripts and
foreignObject.
- “Draw graphics” is not a technical term. A clearer phrase would be something like “static visual rendering elements such as
<rect>,<circle>,<line>,<path>.” - The requirement doesn’t explain when validation should happen, whether at upload time, render time, or both.
- It doesn’t mention any recommended tools or libraries. I think It should also recommend using established, actively maintained SVG sanitization libraries with a strong security track record.
- "Validated or sanitize" this confuse the developer, It should emphasize strict allowlisting of SVG tags and attributes, never depend on general-purpose sanitization for SVG.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the raw Markdown requirements in the 5.0 branch, locate requirement 1.3.4, and review the issue's proposed wording changes. Compare the surrounding ASVS requirements for terminology and scope. Done means the requirement clearly defines safe SVG content and the expected validation or sanitization guidance, with the discussion resolved in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- documentation, security
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100