ORNL / ORNL/flowcept

Test if we are updating custom_metadata in workflows

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority:medium
Dominant language
Python
Stars
36
Forks
19
PR merge metrics
No merged PRs in 30d

Description

for dictionary fields, like custom_metadata especially,
# test if we are updating or replacing when
# an existing wf already has custom_metadata and we call this method

https://github.com/ORNL/flowcept/blob/bbbeb5530e0abbb5dad624b9bd27a2b41aa686c8/flowcept/commons/daos/document_db_dao.py#L293

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at flowcept/commons/daos/document_db_dao.py around line 293 and inspect the workflow update method. Add a test with an existing workflow that already has custom_metadata, call the method, and make the expected update-versus-replace behavior explicit in the test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
database
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.