ORNL / ORNL/flowcept

Apparent duplicate code for JSON serialization

Open
#110 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code-enhancement priority:low
Dominant language
Python
Stars
36
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Needs further assessment, as the settings.yaml has the following:

  json_serializer: default # or complex. If "complex", FlowCept will deal with complex python dicts that may contain JSON unserializable values
  replace_non_json_serializable: true

which seems duplicate

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing settings.yaml and comparing the documented behavior of json_serializer with replace_non_json_serializable. Determine whether the options overlap and record a clear conclusion or follow-up action; the issue is complete when the apparent duplication has been assessed and the configuration's intended behavior is unambiguous.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.