D2630R4 LWG feedback: 2023/05/31
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
@crtrott @dalg24
Most recent changes reviewed
Changes that were OK
- [mdspan.submdspan.overview] para 1, OK.
- [mdspan.submdspan.overview] para 2.5, OK, more legible now.
Requested changes
- In Section 3.1, please highlight additions in green (for changes in [contents]).
- For hidden friends, declarations should appear in the class synopses as well (they already do; that declaration is correct). We don't want that
mapping::scope because it's not valid C++. Otherwise, the coalesced wording is fine. We could even just remove themapping::and put each declaration as a friend in its relevant mapping. We can still describe them here. Wait until later; Jonathan Wakely will e-mail us with a suggestion (the template parameters as displayed aren't correct). There may actually be an outstanding LWG issue about wording for hidden friends.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Section 3.1 and the cited mdspan.submdspan.overview changes in the proposal. Wait for Jonathan Wakely's suggestion before changing the hidden-friend wording; done means additions are highlighted in green and the agreed declarations no longer use the invalid mapping:: scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100