ORNL / ORNL/cpp-proposals-pub

P1673: Should sqrt be a customization point?

Open
#363 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
29
Forks
26
PR merge metrics
No merged PRs in 30d

Description

@crtrott This issue addresses the remaining P1673 points in #281.

  1. Specify whether we are using std::sqrt (or ::sqrt) (important, because it has user-visible side effects like errno).
  2. Is sqrt a customization point, like abs and conj are? If so, add it to front matter.

The second point asks whether P1673 should make sqrt a customization point, just like conj-if-needed. sqrt has the problem that it turns integral arguments into double. Thus, it has type preservation issues analogous to conj. However, unlike conj, we can't trivially fix sqrt for integral arguments.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the remaining P1673 points referenced from #281 and the surrounding proposal text. Resolve whether sqrt uses std::sqrt or ::sqrt and whether it is a customization point; done means the decision is documented and the relevant front matter is updated if needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.